sam/sfizz
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #619 from jpcima/voice-manager-fix

Browse source 
Fix voice groups destroyed after polyphony changed
This commit is contained in:
JP Cimalando 2021-02-02 12:56:26 +01:00 • committed by GitHub
commit 0a6382777e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/sfizz/PolyphonyGroup.cpp
View file

@ -17,6 +17,11 @@ void sfz::PolyphonyGroup::removeVoice(const Voice* voice) noexcept
swapAndPopFirst(voices, [voice](const Voice* v) { return v == voice; });
}
void sfz::PolyphonyGroup::removeAllVoices() noexcept
{
voices.clear();
}
unsigned sfz::PolyphonyGroup::numPlayingVoices() const noexcept
{
return absl::c_count_if(voices, [](const Voice* v) {

4
src/sfizz/PolyphonyGroup.h
View file

@ -35,6 +35,10 @@ public:
* @param voice
*/
void removeVoice(const Voice* voice) noexcept;
/**
* @brief Remove all the voices from this polyphony group.
*/
void removeAllVoices() noexcept;
/**
* @brief Get the polyphony limit for this group
*

27
src/sfizz/VoiceManager.cpp
View file

@ -13,17 +13,22 @@ namespace sfz {
void VoiceManager::onVoiceStateChanging(NumericId<Voice> id, Voice::State state)
{
(void)id;
if (state == Voice::State::idle) {
auto voice = getVoiceById(id);
RegionSet::removeVoiceFromHierarchy(voice->getRegion(), voice);
Voice* voice = getVoiceById(id);
const Region* region = voice->getRegion();
const uint32_t group = region->group;
RegionSet::removeVoiceFromHierarchy(region, voice);
swapAndPopFirst(activeVoices_, [voice](const Voice* v) { return v == voice; });
polyphonyGroups_[voice->getRegion()->group].removeVoice(voice);
ASSERT(group < polyphonyGroups_.size());
polyphonyGroups_[group].removeVoice(voice);
} else if (state == Voice::State::playing) {
auto voice = getVoiceById(id);
Voice* voice = getVoiceById(id);
const Region* region = voice->getRegion();
const uint32_t group = region->group;
activeVoices_.push_back(voice);
RegionSet::registerVoiceInHierarchy(voice->getRegion(), voice);
polyphonyGroups_[voice->getRegion()->group].registerVoice(voice);
RegionSet::registerVoiceInHierarchy(region, voice);
ASSERT(group < polyphonyGroups_.size());
polyphonyGroups_[group].registerVoice(voice);
}
}
@ -81,8 +86,9 @@ bool VoiceManager::playingAttackVoice(const Region* releaseRegion) noexcept
void VoiceManager::ensureNumPolyphonyGroups(unsigned groupIdx) noexcept
{
while (polyphonyGroups_.size() <= groupIdx)
polyphonyGroups_.emplace_back();
size_t neededSize = static_cast<size_t>(groupIdx) + 1;
if (polyphonyGroups_.size() < neededSize)
polyphonyGroups_.resize(neededSize);
}
void VoiceManager::setGroupPolyphony(unsigned groupIdx, unsigned polyphony) noexcept
@ -99,7 +105,8 @@ const PolyphonyGroup* VoiceManager::getPolyphonyGroupView(int idx) const noexcep
void VoiceManager::clear()
{
reset();
for (PolyphonyGroup& pg : polyphonyGroups_)
pg.removeAllVoices();
list_.clear();
activeVoices_.clear();
}