sam/sfizz
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

CI update

Browse source 
- Make bash|pwsh default shells and github.workspace as default working-directory
- Use ubuntu 22.04 for the Linux build to use abseil package when not building releases
- CTest working in the major OS builds
This commit is contained in:
redtide 2023-05-21 15:49:23 +02:00
parent cfba6fa16f
commit 54b6791b9d
No known key found for this signature in database
2 changed files with 131 additions and 97 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

218
.github/workflows/build.yml vendored
View file

@ -16,6 +16,9 @@ on:
env: env:
build_type: Release build_type: Release
# defaults:
# shell: pwsh on windows, bash all the rest
# working-directory: ${{ github.workspace }}
jobs: jobs:
clang_tidy: clang_tidy:
# if: ${{ false }} # if: ${{ false }}
@ -29,12 +32,12 @@ jobs:
- name: Install dependencies - name: Install dependencies
run: sudo apt-get update && sudo apt-get install clang-tidy run: sudo apt-get update && sudo apt-get install clang-tidy
- name: Run - name: Run
run: cd "$GITHUB_WORKSPACE" && scripts/run_clang_tidy.sh run: ./scripts/run_clang_tidy.sh
build_for_linux: build_for_linux:
# if: ${{ false }} # if: ${{ false }}
name: Linux Ubuntu 20.04 name: Linux Ubuntu 22.04
runs-on: ubuntu-20.04 runs-on: ubuntu-22.04 # abseil (libabsl) is not available in 20.04 repository
env: env:
install_name: sfizz-${{ github.ref_name }}-linux install_name: sfizz-${{ github.ref_name }}-linux
steps: steps:
@ -47,14 +50,18 @@ jobs:
sudo apt-get update && sudo apt-get install \ sudo apt-get update && sudo apt-get install \
ninja-build \ ninja-build \
libjack-jackd2-dev libjack-jackd2-dev
- name: Install abseil
if: ${{ github.ref_type == 'branch' }}
run: |
sudo apt-get install \
libabsl-dev \
libabsl20210324
- name: Configure CMake - name: Configure CMake
shell: bash
working-directory: ${{ runner.workspace }}
run: | run: |
options=( options=(
-G Ninja -G Ninja
-B build -B build
-S "$GITHUB_WORKSPACE" -S .
-D CMAKE_BUILD_TYPE=${{ env.build_type }} -D CMAKE_BUILD_TYPE=${{ env.build_type }}
-D CMAKE_CXX_STANDARD=17 -D CMAKE_CXX_STANDARD=17
-D SFIZZ_JACK=ON -D SFIZZ_JACK=ON
@ -62,31 +69,48 @@ jobs:
-D SFIZZ_SHARED=ON -D SFIZZ_SHARED=ON
-D SFIZZ_TESTS=ON -D SFIZZ_TESTS=ON
) )
if [[ ${{ github.ref_type }} == 'branch' ]]; then
options=(
${options[@]}
-D SFIZZ_USE_SYSTEM_ABSEIL=ON
)
fi
cmake "${options[@]}" cmake "${options[@]}"
echo "-- github.workspace: ${{ github.workspace }}"
echo "-- runner.workspace: ${{ runner.workspace }}"
- name: Build tests - name: Build tests
shell: bash
working-directory: ${{ runner.workspace }}
run: | run: |
cmake \ options=(
--build build \ --build build
--config ${{ env.build_type }} \ --config ${{ env.build_type }}
--target sfizz_tests \ --parallel 2
--verbose \ --target sfizz_tests
-j 2 --verbose
)
cmake "${options[@]}"
- name: Run tests - name: Run tests
shell: bash run: |
run: ${{ runner.workspace }}/build/tests/sfizz_tests ./build/tests/sfizz_tests
- name: CTest options=(
working-directory: ${{ runner.workspace }}/build --build-config ${{ env.build_type }}
run: ctest -j 2 -C ${{ env.build_type }} --output-on-failure --debug
- name: Build --extra-verbose
shell: bash --output-on-failure
working-directory: ${{ runner.workspace }} --parallel 2
run: cmake --build build --config ${{ env.build_type }} --verbose -j 2 --test-dir build
)
ctest "${options[@]}"
- name: Build all
run: |
options=(
--build build
--config ${{ env.build_type }}
--parallel 2
--verbose
)
cmake "${options[@]}"
- name: Create tarball - name: Create tarball
if: ${{ github.ref_type == 'tag' }} if: ${{ github.ref_type == 'tag' }}
working-directory: ${{ runner.workspace }}
shell: bash
run: | run: |
DESTDIR="$(pwd)/${{ env.install_name }}" \ DESTDIR="$(pwd)/${{ env.install_name }}" \
cmake --build build --config ${{ env.build_type }} --target install cmake --build build --config ${{ env.build_type }} --target install
@ -96,7 +120,7 @@ jobs:
uses: actions/upload-artifact@v3 uses: actions/upload-artifact@v3
with: with:
name: Linux tarball name: Linux tarball
path: "${{ runner.workspace }}/${{ env.install_name }}.tar.gz" path: "${{ github.workspace }}/${{ env.install_name }}.tar.gz"
build_for_macos: build_for_macos:
# if: ${{ false }} # if: ${{ false }}
@ -113,12 +137,10 @@ jobs:
if: ${{ github.ref_type == 'branch' }} if: ${{ github.ref_type == 'branch' }}
run: brew install abseil run: brew install abseil
- name: Configure CMake - name: Configure CMake
shell: bash
working-directory: ${{ runner.workspace }}
run: | run: |
options=( options=(
-B build -B build
-S "$GITHUB_WORKSPACE" -S .
-D CMAKE_BUILD_TYPE=${{ env.build_type }} -D CMAKE_BUILD_TYPE=${{ env.build_type }}
-D SFIZZ_JACK=OFF -D SFIZZ_JACK=OFF
-D SFIZZ_SHARED=ON -D SFIZZ_SHARED=ON
@ -131,30 +153,41 @@ jobs:
) )
fi fi
cmake "${options[@]}" cmake "${options[@]}"
echo "-- runner.workspace: ${{ runner.workspace }}"
echo "-- github.workspace: ${{ github.workspace }}"
- name: Build tests - name: Build tests
shell: bash
working-directory: ${{ runner.workspace }}
run: | run: |
cmake \ options=(
--build build \ --build build
--config ${{ env.build_type }} \ --config ${{ env.build_type }}
--target sfizz_tests \ --parallel 2
--verbose \ --target sfizz_tests
-j 2 --verbose
)
cmake "${options[@]}"
- name: Run tests - name: Run tests
shell: bash run: |
run: ${{ runner.workspace }}/build/tests/sfizz_tests ./build/tests/sfizz_tests
- name: CTest options=(
working-directory: ${{ runner.workspace }}/build --build-config ${{ env.build_type }}
run: ctest -j 2 -C ${{ env.build_type }} --output-on-failure --debug
- name: Build --extra-verbose
shell: bash --output-on-failure
working-directory: ${{ runner.workspace }} --parallel 2
run: cmake --build build --config ${{ env.build_type }} --verbose -j 2 --test-dir build
)
ctest "${options[@]}"
- name: Build all
run: |
options=(
--build build
--config ${{ env.build_type }}
--parallel 2
--verbose
)
cmake "${options[@]}"
- name: Create tarball - name: Create tarball
if: ${{ github.ref_type == 'tag' }} if: ${{ github.ref_type == 'tag' }}
shell: bash
working-directory: ${{ runner.workspace }}
run: | run: |
DESTDIR="$(pwd)/${{ env.install_name }}" \ DESTDIR="$(pwd)/${{ env.install_name }}" \
cmake --build build --config ${{ env.build_type }} --target install cmake --build build --config ${{ env.build_type }} --target install
@ -164,7 +197,7 @@ jobs:
uses: actions/upload-artifact@v3 uses: actions/upload-artifact@v3
with: with:
name: macOS tarball name: macOS tarball
path: "${{ runner.workspace }}/${{ env.install_name }}.tar.gz" path: "${{ github.workspace }}/${{ env.install_name }}.tar.gz"
build_for_windows: build_for_windows:
# if: ${{ false }} # if: ${{ false }}
@ -189,40 +222,51 @@ jobs:
with: with:
submodules: recursive submodules: recursive
- name: Configure CMake - name: Configure CMake
working-directory: ${{ runner.workspace }}
run: | run: |
cmake ` cmake `
-G "Visual Studio 16 2019" ` -G "Visual Studio 16 2019" `
-A "${{ matrix.release_arch }}" ` -A "${{ matrix.release_arch }}" `
-B build ` -B build `
-S "${Env:GITHUB_WORKSPACE}" ` -S . `
-D CMAKE_BUILD_TYPE=${{ env.build_type }} ` -D CMAKE_BUILD_TYPE=${{ env.build_type }} `
-D CMAKE_CXX_STANDARD=17 ` -D CMAKE_CXX_STANDARD=17 `
-D SFIZZ_TESTS=ON ` -D SFIZZ_TESTS=ON
echo "-- runner.workspace: ${{ runner.workspace }}"
echo "-- github.workspace: ${{ github.workspace }}"
- name: Build tests - name: Build tests
working-directory: ${{ runner.workspace }}
run: | run: |
cmake ` cmake `
--build build ` --build build `
--config ${{ env.build_type }} ` --config ${{ env.build_type }} `
--parallel 2 `
--target sfizz_tests ` --target sfizz_tests `
--verbose ` --verbose `
-j 2 ` - name: Run tests
- name: Test run: |
run: ${{ runner.workspace }}\build\tests\${{ env.build_type }}\sfizz_tests.exe .\build\tests\${{ env.build_type }}\sfizz_tests.exe
- name: Build ctest `
working-directory: ${{ runner.workspace }} --build-config ${{ env.build_type }} `
run: cmake --build build --config ${{ env.build_type }} --verbose -j 2 --debug `
--extra-verbose `
--output-on-failure `
--parallel 2 `
--test-dir build `
- name: Build all
run: |
cmake `
--build build `
--config ${{ env.build_type }} `
--parallel 2 `
--verbose `
- name: Create zip package - name: Create zip package
if: ${{ github.ref_type == 'tag' }} if: ${{ github.ref_type == 'tag' }}
working-directory: ${{ runner.workspace }}
run: 7z a "${{ env.install_name }}.zip" ".\build\src\${{ env.build_type }}\sfizz.*" run: 7z a "${{ env.install_name }}.zip" ".\build\src\${{ env.build_type }}\sfizz.*"
- name: Upload - name: Upload
if: ${{ github.ref_type == 'tag' }} if: ${{ github.ref_type == 'tag' }}
uses: actions/upload-artifact@v3 uses: actions/upload-artifact@v3
with: with:
name: ${{ matrix.pkg_platform }} zip package name: ${{ matrix.pkg_platform }} zip package
path: "${{ runner.workspace }}/${{ env.install_name }}.zip" path: "${{ github.workspace }}/${{ env.install_name }}.zip"
archive_source_code: archive_source_code:
# if: startsWith(github.ref, 'refs/tags/') # if: startsWith(github.ref, 'refs/tags/')
@ -241,16 +285,15 @@ jobs:
sudo apt-get update && sudo apt-get install python3-pip sudo apt-get update && sudo apt-get install python3-pip
sudo pip install git-archive-all sudo pip install git-archive-all
- name: Archive source code - name: Archive source code
shell: bash
run: | run: |
cd "$GITHUB_WORKSPACE" && git-archive-all \ git-archive-all \
--prefix="${{ env.install_name }}/" \ --prefix="${{ env.install_name }}/" \
-9 "${{ runner.workspace }}/${{ env.install_name }}.tar.gz" -9 "${{ github.workspace }}/${{ env.install_name }}.tar.gz"
- name: Upload - name: Upload
uses: actions/upload-artifact@v3 uses: actions/upload-artifact@v3
with: with:
name: Source code tarball name: Source code tarball
path: "${{ runner.workspace }}/${{ env.install_name }}.tar.gz" path: "${{ github.workspace }}/${{ env.install_name }}.tar.gz"
build_for_mingw: build_for_mingw:
if: ${{ false }} # DISABLED TEMPORARILY if: ${{ false }} # DISABLED TEMPORARILY
@ -271,7 +314,6 @@ jobs:
install_name: sfizz-${{ github.ref_name }}-mingw${{ matrix.bits }} install_name: sfizz-${{ github.ref_name }}-mingw${{ matrix.bits }}
steps: steps:
- name: Configure pacman repositories - name: Configure pacman repositories
shell: bash
run: | run: |
cat >>/etc/pacman.conf <<EOF cat >>/etc/pacman.conf <<EOF
[multilib] [multilib]
@ -281,7 +323,6 @@ jobs:
Server = https://github.com/jpcima/arch-mingw-w64/releases/download/repo.\$arch/ Server = https://github.com/jpcima/arch-mingw-w64/releases/download/repo.\$arch/
EOF EOF
- name: Install dependencies - name: Install dependencies
shell: bash
run: | run: |
packages=( packages=(
base-devel git ninja wget base-devel git ninja wget
@ -293,18 +334,15 @@ jobs:
with: with:
submodules: recursive submodules: recursive
- name: Fix MinGW headers - name: Fix MinGW headers
shell: bash
run: | run: |
cp -vf "$GITHUB_WORKSPACE"/scripts/mingw_dwrite_3.h \ cp -vf "${{ github.workspace }}"/scripts/mingw_dwrite_3.h \
/usr/${{ matrix.platform }}-w64-mingw32/include/dwrite_3.h /usr/${{ matrix.platform }}-w64-mingw32/include/dwrite_3.h
- name: Configure CMake - name: Configure CMake
shell: bash
working-directory: ${{ runner.workspace }}
run: | run: |
options=( options=(
-G Ninja -G Ninja
-B build -B build
-S "$GITHUB_WORKSPACE" -S .
-D CMAKE_BUILD_TYPE=${{ env.build_type }} -D CMAKE_BUILD_TYPE=${{ env.build_type }}
-D CMAKE_CXX_STANDARD=17 -D CMAKE_CXX_STANDARD=17
-D ENABLE_LTO=OFF -D ENABLE_LTO=OFF
@ -313,14 +351,10 @@ jobs:
) )
${{ matrix.platform }}-w64-mingw32-cmake "${options[@]}" ${{ matrix.platform }}-w64-mingw32-cmake "${options[@]}"
- name: Build - name: Build
shell: bash
working-directory: ${{ runner.workspace }}
run: ${{ matrix.platform }}-w64-mingw32-cmake \ run: ${{ matrix.platform }}-w64-mingw32-cmake \
--build build --config ${{ env.build_type }} --verbose -j 2 --build build --config ${{ env.build_type }} --verbose -j 2
- name: Install - name: Install
if: ${{ github.ref_type == 'tag' }} if: ${{ github.ref_type == 'tag' }}
working-directory: ${{ runner.workspace }}
shell: bash
run: | run: |
DESTDIR="$(pwd)/${{ env.install_name }}" \ DESTDIR="$(pwd)/${{ env.install_name }}" \
${{ matrix.platform }}-w64-mingw32-cmake \ ${{ matrix.platform }}-w64-mingw32-cmake \
@ -331,7 +365,7 @@ jobs:
uses: actions/upload-artifact@v3 uses: actions/upload-artifact@v3
with: with:
name: ${{ matrix.pkg_platform }} MinGW tarball name: ${{ matrix.pkg_platform }} MinGW tarball
path: "${{ runner.workspace }}/${{ env.install_name }}.tar.gz" path: "${{ github.workspace }}/${{ env.install_name }}.tar.gz"
build_with_libsndfile: build_with_libsndfile:
# if: ${{ false }} # if: ${{ false }}
@ -348,13 +382,11 @@ jobs:
ninja-build \ ninja-build \
libsndfile1-dev libsndfile1-dev
- name: Configure CMake - name: Configure CMake
shell: bash
working-directory: ${{ runner.workspace }}
run: | run: |
options=( options=(
-G Ninja -G Ninja
-B build -B build
-S "$GITHUB_WORKSPACE" -S .
-D CMAKE_BUILD_TYPE=${{ env.build_type }} -D CMAKE_BUILD_TYPE=${{ env.build_type }}
-D SFIZZ_JACK=OFF -D SFIZZ_JACK=OFF
-D SFIZZ_RENDER=OFF -D SFIZZ_RENDER=OFF
@ -364,12 +396,17 @@ jobs:
) )
cmake "${options[@]}" cmake "${options[@]}"
- name: Build tests - name: Build tests
shell: bash run: |
working-directory: ${{ runner.workspace }} options=(
run: cmake --build build -j 2 --target sfizz_tests --build build
--config ${{ env.build_type }}
--parallel 2
--target sfizz_tests
--verbose
)
cmake "${options[@]}"
- name: Run tests - name: Run tests
shell: bash run: ./build/tests/sfizz_tests
run: ${{ runner.workspace }}/build/tests/sfizz_tests
build_with_makefile: build_with_makefile:
# if: ${{ false }} # if: ${{ false }}
@ -381,12 +418,10 @@ jobs:
with: with:
submodules: recursive submodules: recursive
- name: Build with GNU make - name: Build with GNU make
shell: bash run: make -C "${{ github.workspace }}" -f generic.mk -j2
run: make -C "$GITHUB_WORKSPACE" -f generic.mk -j2
- name: Compile a simple program - name: Compile a simple program
shell: bash
run: | run: |
cat <<EOF > "$GITHUB_WORKSPACE"/simple.cpp cat <<EOF > "${{ github.workspace }}"/simple.cpp
#include <sfizz.hpp> #include <sfizz.hpp>
int main() { int main() {
sfz::Sfizz synth; sfz::Sfizz synth;
@ -394,7 +429,7 @@ jobs:
return 0; return 0;
} }
EOF EOF
cat <<EOF > "$GITHUB_WORKSPACE"/simple.mk cat <<EOF > "${{ github.workspace }}"/simple.mk
all: simple all: simple
include generic.mk include generic.mk
simple.o: simple.cpp simple.o: simple.cpp
@ -402,7 +437,7 @@ jobs:
simple: simple.o \$(SFIZZ_TARGET) simple: simple.o \$(SFIZZ_TARGET)
\$(CXX) -o \$@ \$^ \$(SFIZZ_LINK_FLAGS) \$(LDFLAGS) \$(CXX) -o \$@ \$^ \$(SFIZZ_LINK_FLAGS) \$(LDFLAGS)
EOF EOF
make -C "$GITHUB_WORKSPACE" -f simple.mk make -C "${{ github.workspace }}" -f simple.mk
deploy: deploy:
if: ${{ github.ref_type == 'tag' }} if: ${{ github.ref_type == 'tag' }}
@ -448,7 +483,6 @@ jobs:
name: Source code tarball name: Source code tarball
- name: Display file information - name: Display file information
shell: bash
run: ls -lR run: ls -lR
- name: Release - name: Release

10
tests/FilesT.cpp
View file

@ -779,9 +779,10 @@ TEST_CASE("[Files] Unused samples are cleared on reloading")
REQUIRE(synth.getNumPreloadedSamples() == 0); REQUIRE(synth.getNumPreloadedSamples() == 0);
} }
// FIXME: this breaks on Github win32/win64/linux CI "sometimes" but I can't reproduce it reliably // FIXME:
// Not sure the second test fails too but in doubt... // this breaks on Github win32/win64/linux CI "sometimes"
#if 0 // but I can't reproduce it reliably.
#if !defined(_WIN32) && !defined(_WIN64) && !defined(__APPLE__)
TEST_CASE("[Files] Embedded sample data") TEST_CASE("[Files] Embedded sample data")
{ {
sfz::Synth synth1; sfz::Synth synth1;
@ -816,7 +817,7 @@ TEST_CASE("[Files] Embedded sample data")
REQUIRE(tmp1 == tmp2); REQUIRE(tmp1 == tmp2);
} }
} }
#endif
TEST_CASE("[Files] Key center from audio file, with embedded sample data") TEST_CASE("[Files] Key center from audio file, with embedded sample data")
{ {
sfz::Synth synth; sfz::Synth synth;
@ -830,4 +831,3 @@ TEST_CASE("[Files] Key center from audio file, with embedded sample data")
REQUIRE(synth.getRegionView(4)->pitchKeycenter == 10); REQUIRE(synth.getRegionView(4)->pitchKeycenter == 10);
REQUIRE(synth.getRegionView(5)->pitchKeycenter == 62); REQUIRE(synth.getRegionView(5)->pitchKeycenter == 62);
} }
#endif