From 38b36522ef767d9b31dc73b068356260daa7818c Mon Sep 17 00:00:00 2001 From: Jean Pierre Cimalando Date: Mon, 26 Apr 2021 10:45:06 +0200 Subject: [PATCH 1/3] Add min/max specifications for LV2 controllers --- cmake/LV2Config.cmake | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cmake/LV2Config.cmake b/cmake/LV2Config.cmake index 5a6fb044..a7ca3cd1 100644 --- a/cmake/LV2Config.cmake +++ b/cmake/LV2Config.cmake @@ -62,7 +62,9 @@ function(sfizz_lv2_generate_controllers_ttl FILE) sfizz:cc${_i} a lv2:Parameter ; rdfs:label \"Controller ${_i}\" ; - rdfs:range atom:Float") + rdfs:range atom:Float ; + lv2:minimum 0.0 ; + lv2:maximum 1.0") if(_i LESS 128 AND NOT SFIZZ_LV2_PSA) math(EXPR _digit1 "${_i}>>4") From e17b6e7d52cb9c458c54df9cfa425ba3d8dd8f96 Mon Sep 17 00:00:00 2001 From: Jean Pierre Cimalando Date: Mon, 26 Apr 2021 10:52:19 +0200 Subject: [PATCH 2/3] Put LV2 stereo outputs in a group --- plugins/lv2/sfizz.ttl.in | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/plugins/lv2/sfizz.ttl.in b/plugins/lv2/sfizz.ttl.in index 38868a56..f92b274f 100644 --- a/plugins/lv2/sfizz.ttl.in +++ b/plugins/lv2/sfizz.ttl.in @@ -23,6 +23,13 @@ midnam:interface a lv2:ExtensionData . midnam:update a lv2:Feature . +<@LV2PLUGIN_URI@#stereo_output> + a pg:StereoGroup, pg:OutputGroup ; + lv2:symbol "stereo_output" ; + lv2:name "Stereo output", + "Sortie stéréo"@fr , + "Uscita stereo"@it . + <@LV2PLUGIN_URI@#config> a pg:Group ; lv2:symbol "config" ; @@ -125,14 +132,18 @@ midnam:update a lv2:Feature . lv2:symbol "out_left" ; lv2:name "Left Output", "Sortie gauche"@fr , - "Uscita Sinistra"@it + "Uscita Sinistra"@it ; + pg:group <@LV2PLUGIN_URI@#stereo_output> ; + lv2:designation pg:left ] , [ a lv2:AudioPort, lv2:OutputPort ; lv2:index 4 ; lv2:symbol "out_right" ; lv2:name "Right Output", "Sortie droite"@fr , - "Uscita Destra"@it + "Uscita Destra"@it ; + pg:group <@LV2PLUGIN_URI@#stereo_output> ; + lv2:designation pg:right ] , [ a lv2:InputPort, lv2:ControlPort ; lv2:index 5 ; From c046c630147792838b252e0ce4b0b3fb1e6f8be1 Mon Sep 17 00:00:00 2001 From: Jean Pierre Cimalando Date: Mon, 26 Apr 2021 10:53:04 +0200 Subject: [PATCH 3/3] Fix a typo --- plugins/lv2/sfizz.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/lv2/sfizz.cpp b/plugins/lv2/sfizz.cpp index ec8e1518..6a001e72 100644 --- a/plugins/lv2/sfizz.cpp +++ b/plugins/lv2/sfizz.cpp @@ -478,7 +478,7 @@ instantiate(const LV2_Descriptor *descriptor, else { lv2_log_warning(&self->logger, - "No option array was given upon instantiation; will use default values\n."); + "No option array was given upon instantiation; will use default values.\n"); } // We need _some_ information on the block size