sam/sfizz
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lv2/sfizz.c: options terminator must have both key and value as 0

Browse source 
This fixes the problem with such a condition that a host passes a list of 
options where any option with value `0` precedes the block sizes.

From http://lv2plug.in/ns/ext/options#options:

> To implement this feature, hosts MUST pass an LV2_Feature to the appropriate instantiate method with this URI and data pointed to an array of LV2_Options_Option terminated by an element with both key and value set to zero.
This commit is contained in:
Atsushi Eno 2020-07-18 21:35:06 +09:00 • committed by GitHub
parent 4a402a45f8
commit 6582285f21
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lv2/sfizz.c
View file

@ -413,7 +413,7 @@ instantiate(const LV2_Descriptor *descriptor,
// Check the options for the block size and sample rate parameters
if (options)
{
for (const LV2_Options_Option *opt = options; opt->value; ++opt)
for (const LV2_Options_Option *opt = options; opt->key || opt->value; ++opt)
{
if (opt->key == self->sample_rate_uri)
{
@ -845,7 +845,7 @@ lv2_get_options(LV2_Handle instance, LV2_Options_Option *options)
{
sfizz_plugin_t *self = (sfizz_plugin_t *)instance;
LV2_DEBUG("[DEBUG] get_options called\n");
for (LV2_Options_Option *opt = options; opt->value; ++opt)
for (LV2_Options_Option *opt = options; opt->key || opt->value; ++opt)
{
if (self->unmap) {
LV2_DEBUG("[DEBUG] Called for an option with key (subject): %s (%s) \n",
@ -878,7 +878,7 @@ lv2_set_options(LV2_Handle instance, const LV2_Options_Option *options)
sfizz_plugin_t *self = (sfizz_plugin_t *)instance;
// Update the block size and sample rate as needed
for (const LV2_Options_Option *opt = options; opt->value; ++opt)
for (const LV2_Options_Option *opt = options; opt->key || opt->value; ++opt)
{
if (opt->key == self->sample_rate_uri)
{